Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: upgrade to Remix v2 #257

Merged
merged 1 commit into from
Sep 15, 2023
Merged

feat: upgrade to Remix v2 #257

merged 1 commit into from
Sep 15, 2023

Conversation

MichaelDeBoey
Copy link
Member

@MichaelDeBoey MichaelDeBoey commented Sep 5, 2023 •
edited
Loading

No description provided.

This was referenced Sep 6, 2023
Merged
Merged
@brophdawg11
Copy link
Contributor

Oops! Totally missed this PR. I took a stab at this as well to se if we could punt on #255 for the time being since converting to ESM is not a prerequisite for v2 compatibility. We can launch v2 with the indie stack on CJS and then convert it to ESM separately.

Here's my changes which I confirmed instaleld correctly against the latest prerelease: main...v2

I imagine the only thing that's not in here is the changes to Response and Readble.toWeb in entry.server since the latest prerelease contains the fetch changes

@brophdawg11 brophdawg11 mentioned this pull request Sep 6, 2023
Merged
@MichaelDeBoey
Copy link
Member Author

MichaelDeBoey commented Sep 6, 2023 •
edited
Loading

@brophdawg11 Just rebased this branch on main so we can merge this independently

I'll keep it as draft until v2 is released stably

@MichaelDeBoey MichaelDeBoey marked this pull request as ready for review September 6, 2023 20:57
@MichaelDeBoey MichaelDeBoey marked this pull request as draft September 6, 2023 20:58
brophdawg11
brophdawg11 reviewed Sep 12, 2023
View reviewed changes
Copy link
Contributor

@brophdawg11 brophdawg11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good to me! Just a few small comments. I tested with the following and it ran great and I was able to load the site and login with the default user:

> npx create-remix@pre --template https://github.com/MichaelDeBoey/indie-stack/tree/v2 -y indie-v2
> cd indie-v2
> npx upgrade-remix pre
> npm run dev

app/entry.server.tsx Outdated Show resolved Hide resolved
app/entry.server.tsx Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
@MichaelDeBoey MichaelDeBoey marked this pull request as ready for review September 15, 2023 19:02
@MichaelDeBoey MichaelDeBoey merged commit 6453ae0 into remix-run:main Sep 15, 2023
6 checks passed
@MichaelDeBoey MichaelDeBoey mentioned this pull request Sep 17, 2023
Merged
@richard-paystack richard-paystack mentioned this pull request Sep 26, 2023
Merged
5 tasks
@MichaelDeBoey MichaelDeBoey mentioned this pull request Nov 4, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markdalgleish markdalgleish Awaiting requested review from markdalgleish

@pcattori pcattori Awaiting requested review from pcattori

@jacob-ebey jacob-ebey Awaiting requested review from jacob-ebey

@brophdawg11 brophdawg11 Awaiting requested review from brophdawg11

Assignees
No one assigned
Labels
None yet
Projects
No open projects
v2
Status: Merged
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MichaelDeBoey @brophdawg11