feat: cleanup dist directories when dev mode ends #252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacob-ebey
commented
Aug 20, 2021
| @@ -76,6 +77,11 @@ export async function watch( | |||
| }) | |||
| ); | |||
|
|
|||
| signalExit(() => { | |||
There was a problem hiding this comment.
signal-exit doesn't seem to support async here. Without sync the directories are not cleaned up.
jacob-ebey
deleted the
jacob/rem-187-cleanup-dist-directories-when-dev-server
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we have massive build folders that are left around after a dev server instance is closed. This is due to us writing uniquely hashed files per incremental build. Let's just fully empty the build folders for now.