Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(examples): add file upload to S3 example #3433

Merged
merged 6 commits into from
Jul 22, 2022
Merged

docs(examples): add file upload to S3 example #3433

merged 6 commits into from
Jul 22, 2022

Conversation

TobiasGeiselmann
Copy link
Contributor

@TobiasGeiselmann TobiasGeiselmann commented Jun 9, 2022 •
edited
Loading

Since no example on the internet seemed to handle AsyncIterable correctly, I decided to create a simple example on how to upload a file to an S3 bucket. This example is based on the cloudinary one.

@TobiasGeiselmann
S3 file upload (#1)
df2359c 
* Implemented S3 upload

* Updated README

* Cleaned up dependencies
@TobiasGeiselmann
Revert "S3 file upload (#1)" (#2)
37b9976 
This reverts commit df2359c.
@TobiasGeiselmann
S3 file upload (#3)
37d8ec8 
* Implemented S3 upload

* Updated README

* Cleaned up dependencies
@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented Jun 9, 2022

Hi @gst4r,

Welcome, and thank you for contributing to Remix!

Before we consider your pull request, we ask that you sign our Contributor License Agreement (CLA). We require this only once.

You may review the CLA and sign it by adding your name to contributors.yml.

Once the CLA is signed, the CLA Signed label will be added to the pull request.

If you have already signed the CLA and received this response in error, or if you have any questions, please contact us at hello@remix.run.

Thanks!

- The Remix team

@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented Jun 9, 2022

Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳

kentcdodds
kentcdodds requested changes Jul 18, 2022
View reviewed changes
Copy link
Member

@kentcdodds kentcdodds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks awesome! Thank you for taking the time to put this together. Could you make one change?

examples/file-and-s3-upload/app/routes/s3-upload.tsx Outdated Show resolved Hide resolved
@TobiasGeiselmann
S3 file upload (#4)
19c1495 
* Implemented S3 upload

* Updated README

* Updated README

* Cleaned up dependencies

* Fixed dependencies

* Refactored from useActionData to useFetcher
@changeset-bot
Copy link

changeset-bot bot commented Jul 21, 2022

⚠️ No Changeset found

Latest commit: 19c1495

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

kentcdodds
kentcdodds approved these changes Jul 22, 2022
View reviewed changes
Copy link
Member

@kentcdodds kentcdodds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@kentcdodds kentcdodds merged commit bea9c0a into remix-run:main Jul 22, 2022
dvargas92495 pushed a commit to dvargas92495/remix that referenced this pull request Jul 22, 2022
@TobiasGeiselmann @dvargas92495
docs(examples): add file upload to S3 example (remix-run#3433)
ae094d2 
* S3 file upload (#1)

* Implemented S3 upload

* Updated README

* Cleaned up dependencies

* Revert "S3 file upload (#1)" (remix-run#2)

This reverts commit df2359c.

* S3 file upload (#3)

* Implemented S3 upload

* Updated README

* Cleaned up dependencies

* Update contributors.yml

* S3 file upload (remix-run#4)

* Implemented S3 upload

* Updated README

* Updated README

* Cleaned up dependencies

* Fixed dependencies

* Refactored from useActionData to useFetcher
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kentcdodds kentcdodds kentcdodds approved these changes

Assignees

@kentcdodds kentcdodds

Labels
CLA Signed examples
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@TobiasGeiselmann @kentcdodds @machour