perf(remix-architect,remix-netlify): improve performance of isBinaryType

.changeset/late-bottles-shop.md

@@ -0,0 +1,9 @@
+---
+"remix": patch
+"@remix-run/architect": patch
+"@remix-run/netlify": patch
+---
+
+improve performance of `isBinaryType` in the netlify and architect adapters
+
+previous implementation from arc itself has a complexity of O(N*includesComplexity), where as now it is O(includesComplexity).

contributors.yml

@@ -155,6 +155,7 @@
 - guatedude2
 - guerra08
 - gunners6518
+- gyx1000
 - hadizz
 - hardingmatt
 - helderburato

packages/remix-architect/__tests__/binaryTypes-test.ts

@@ -0,0 +1,11 @@
+import { isBinaryType } from "../binaryTypes";
+
+describe("architect isBinaryType", () => {
+  it("should detect binary contentType correctly", () => {
+    expect(isBinaryType(undefined)).toBe(false);
+    expect(isBinaryType(null)).toBe(false);
+    expect(isBinaryType("text/html; charset=utf-8")).toBe(false);
+    expect(isBinaryType("application/octet-stream")).toBe(true);
+    expect(isBinaryType("application/octet-stream; charset=test")).toBe(true);
+  });
+});

packages/remix-architect/binaryTypes.ts

@@ -64,5 +64,6 @@ const binaryTypes = [
 
 export function isBinaryType(contentType: string | null | undefined) {
   if (!contentType) return false;
-  return binaryTypes.some((t) => contentType.includes(t));
+  let [test] = contentType.split(";");
+  return binaryTypes.includes(test);
 }

packages/remix-netlify/__tests__/binaryTypes.test.ts

@@ -0,0 +1,11 @@
+import { isBinaryType } from "../binaryTypes";
+
+describe("architect isBinaryType", () => {
+  it("should detect binary contentType correctly", () => {
+    expect(isBinaryType(undefined)).toBe(false);
+    expect(isBinaryType(null)).toBe(false);
+    expect(isBinaryType("text/html; charset=utf-8")).toBe(false);
+    expect(isBinaryType("application/octet-stream")).toBe(true);
+    expect(isBinaryType("application/octet-stream; charset=test")).toBe(true);
+  });
+});

packages/remix-netlify/binaryTypes.ts

@@ -64,5 +64,6 @@ const binaryTypes = [
 
 export function isBinaryType(contentType: string | null | undefined) {
   if (!contentType) return false;
-  return binaryTypes.some((t) => contentType.includes(t));
+  let [test] = contentType.split(";");
+  return binaryTypes.includes(test);
 }