Update CI workflows to cancel based on built-in concurrency setting #7279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
brophdawg11
force-pushed
the
brophdawg11/ci-cancellation
branch
from
b42148f
to
048db8d
Compare
brophdawg11
commented
Aug 28, 2023
| @@ -24,9 +24,6 @@ jobs: | |||
| published_packages: ${{ steps.changesets.outputs.publishedPackages }} | |||
| published: ${{ steps.changesets.outputs.published }} | |||
| steps: | |||
| - name: 🛑 Cancel Previous Runs | |||
| uses: styfle/cancel-workflow-action@0.11.0 | |||
|
|
|||
There was a problem hiding this comment.
I didn't add concurrency to the release workflow since we probably want any started release to finish? For example if we start a pre.0 release and then quickly fix a bug and kick off a pre.1 - we would want them both to complete and publish to npm instead of leaving a gap in the prereleases?
MichaelDeBoey
approved these changes
Aug 28, 2023
brophdawg11
added
the
github_actions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switch to built-in CI job cancellation as recommended in https://github.com/styfle/cancel-workflow-action