feat(dev): get available port if not available #871
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳 |
mcansh
changed the title
|
Let's rebase this on current dev, the config changed a bit. |
|
Also, can LiveReload do the same? |
yeah it does, but we'll need to tell LiveReload in root.tsx about the new port |
mcansh
force-pushed
the
logan/port
branch
2 times, most recently
from
11ff12e
to
e1c883e
Compare
|
Shouldn’t remix/packages/remix-serve/cli.ts Line 6 in 1fd7096 |
kentcdodds
reviewed
Dec 30, 2021
There was a problem hiding this comment.
This would be quite nice! Maybe you could add #1277 to this one? Otherwise the PR is only marginally useful.
kentcdodds
approved these changes
Jan 5, 2022
There was a problem hiding this comment.
This looks good to me. Would love to get this combined with #1352
…lable Signed-off-by: Logan McAnsh <logan@mcan.sh>
Signed-off-by: Logan McAnsh <logan@mcan.sh>
kentcdodds
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
uses get-port instead of incrementing by 1 like #844 and #746
also applies the port checking to the
devServerPortcloses #863, #844, and #746
Signed-off-by: Logan McAnsh logan@mcan.sh