Remove response stub from LoaderFunctionArgs/ActionFunctionArgs #9398
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 394b094 The changes in this PR will be included in the next version bump. This PR includes changesets to release 16 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
brophdawg11
commented
May 9, 2024
| response, | ||
| // Only provided when single fetch is enabled, and made available via | ||
| // `defineAction` types, not `ActionFunctionArgs` | ||
| ...(singleFetch ? { response } : null), |
There was a problem hiding this comment.
This is functionally equivalent, as response is only defined when singleFetch is enabled, but this quiets the type error when response is not in LoaderFunctionArgs
brophdawg11
commented
May 9, 2024
| @@ -59,8 +40,6 @@ export type ActionFunction = ( | |||
| export type ActionFunctionArgs = RRActionFunctionArgs<AppLoadContext> & { | |||
| // Context is always provided in Remix, and typed for module augmentation support. | |||
| context: AppLoadContext; | |||
| // TODO: (v7) Make this non-optional once single-fetch is the default | |||
| response?: ResponseStub; | |||
There was a problem hiding this comment.
Remove the previous ambiguity here. Now users will get no response stub when using LoaderFunctionArgs and a non-optional response stub when using defineLoader
brophdawg11
commented
May 9, 2024
| @@ -27,25 +27,6 @@ export type DataFunctionArgs = RRActionFunctionArgs<AppLoadContext> & | |||
| context: AppLoadContext; | |||
| }; | |||
|
|
|||
| export const ResponseStubOperationsSymbol = Symbol("ResponseStubOperations"); | |||
There was a problem hiding this comment.
Moved alongside the rest of the single fetch types
github-actions
bot
added
the
awaiting release
This was referenced May 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor follow ups to #9372