remove socket listeners on “abort” #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this was done in 4.3.1, but was removed on 4.3.2, so put it back
🦋 Changeset detectedLatest commit: 52f7a50 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Hey y'all, we're having this problem too and would love to get this fix merged! |
|
|
MichaelDeBoey
approved these changes
Apr 27, 2023
|
Is there a plan to merge / publish this? I believe that this is causing breakage with websites with redirects. |
MichaelDeBoey
pushed a commit
to MichaelDeBoey/web-std-io
that referenced
this pull request
Aug 26, 2023
Co-authored-by: Matt Brophy <matt@brophy.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this was done in 4.3.1, but was removed on 4.3.2, so put it back
fixes remix-run/remix#4993