Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle hours resetting at midnight #42

Closed
genhernandez opened this issue Aug 8, 2018 · 3 comments
Closed

Handle hours resetting at midnight #42

genhernandez opened this issue Aug 8, 2018 · 3 comments

Comments

@genhernandez
Copy link

  • partridge version: 0.11.0
  • Python version: 3.6

Description

Seen in Singapore GTFS.

Times go ["23:56:00", "00:02:00"...], and ideally times would be normalized to ["23:56:00", "24:02:00"...].

However, I'm not sure how prevalent this problem is. Any thoughts?

@invisiblefunnel
Copy link
Contributor

@genhernandez thanks for posting this issue. I know we've seen it at Remix a few times.

Has anyone else out there run into this issue? How did you solve it?

@tilgovi
Copy link
Contributor

tilgovi commented Jan 8, 2019

Related (or maybe the same issue) is that GTFS specifies that times are seconds since noon minus 12 hours. For calendar days when there is a daylight savings shift, the float representation of the parsed time is currently incorrect.

@invisiblefunnel
Copy link
Contributor

Closing due to lack of interest. @tilgovi I made your comment a new issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants