Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Float representation of the parsed time is currently incorrect #54

Closed
invisiblefunnel opened this issue Jan 18, 2019 · 2 comments
Closed

Comments

@invisiblefunnel
Copy link
Contributor

Related (or maybe the same issue) is that GTFS specifies that times are seconds since noon minus 12 hours. For calendar days when there is a daylight savings shift, the float representation of the parsed time is currently incorrect.

Originally posted by @tilgovi in #42 (comment)

@invisiblefunnel invisiblefunnel changed the title GTFS specifies that times are seconds since noon minus 12 hours. For calendar days when there is a daylight savings shift, the float representation of the parsed time is currently incorrect. Float representation of the parsed time is currently incorrect Jan 18, 2019
@tilgovi
Copy link
Contributor

tilgovi commented Feb 11, 2019

Since the float representation is only created when reading the feed for transformation purposes, and Partridge does not expose an interfacing for writing the feed back out, it's sufficient to say that these floats are "seconds since noon minus 12h", just as the GTFS specification does with its time representations.

@tilgovi tilgovi closed this as completed Feb 11, 2019
@invisiblefunnel
Copy link
Contributor Author

cc @genhernandez

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants