1615: Fix bug in getCJKAdjustedLength() that double counts supplement… #1616
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remkop
approved these changes
Feb 27, 2022
…ary code points getCJKAdjustedLength calculates the column width of text strings. But it operates on chars which causes it to double count supplementary code points. Supplimentary code points have a high and a low code unit(char). This commit reworks this logic to be based on code points. The code assembles the code points by hand as String.codePoints() was only added in 1.8 and picocli has a source level of 1.5
remkop
force-pushed
the
1615-fix-getCJKAdjustedLength-for-supplementary-code-points
branch
from
4ccad5b
to
843b1bb
Compare
remkop
added a commit
that referenced
this pull request
Mar 2, 2022
|
Merged. Thank you again for the contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ary code points
getCJKAdjustedLength calculates the column width of text strings.
But it operates on chars which causes it to double count supplementary code
points. Supplimentary code points have a high and a low code unit(char).
This commit reworks this logic to be based on code points. The code assembles
the code points by hand as String.codePoints() was only added in 1.8 and
picocli has a source level of 1.5
closes #1615