Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doc improvements #1677

Merged
merged 3 commits into from
May 12, 2022
Merged

Doc improvements #1677

merged 3 commits into from
May 12, 2022

Conversation

Vampire
Copy link
Contributor

@Vampire Vampire commented May 12, 2022

A couple of improvements and mainly fixes to the manual.

I didn't find whether you replace versions manually or somehow automated.
In the last paragraph there is a link to CommandLine.java that still pointed to 4.6.3-SNAPSHOT while the remaining document points to 4.7.0-SNAPSHOT, so however you do the replacement, that spot was missed.

@remkop
Copy link
Owner

remkop commented May 12, 2022

Looks great, thank you!

That 4.6.3-SNAPSHOT version in the doc should have been automatically replaced but wasn't, so thank you for pointing that out. 👍
I need to fix that in the build.

@remkop remkop merged commit ddec200 into remkop:main May 12, 2022
remkop added a commit that referenced this pull request May 12, 2022
remkop added a commit that referenced this pull request May 13, 2022
@remkop
Copy link
Owner

remkop commented May 13, 2022

Turns out I had a typo in the regex for the link to a stable version of the CommandLine.java source code.
Fixed now. ✔️
Thank you again for the contributions! 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants