Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow @Mixin to be used for methods as well #525

Merged
merged 1 commit into from
Oct 22, 2018

Conversation

knutwalker
Copy link
Contributor

This one allows Mixins to be used as method parameters, in particular for subcommands that are defined as methods.

@codecov-io
Copy link

codecov-io commented Oct 21, 2018

Codecov Report

Merging #525 into master will increase coverage by 0.09%.
The diff coverage is 93.93%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #525      +/-   ##
============================================
+ Coverage     89.01%   89.11%   +0.09%     
- Complexity      284      285       +1     
============================================
  Files             4        4              
  Lines          3906     3932      +26     
  Branches        959      964       +5     
============================================
+ Hits           3477     3504      +27     
  Misses          214      214              
+ Partials        215      214       -1
Impacted Files Coverage Δ Complexity Δ
src/main/java/picocli/CommandLine.java 89.14% <93.93%> (+0.1%) 160 <0> (+1) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5ac5cac...7a650e5. Read the comment docs.

@remkop remkop added this to the 3.8 milestone Oct 21, 2018
@remkop remkop added theme: codegen An issue or change related to the picocli-codegen module type: enhancement ✨ type: API 🔌 and removed theme: codegen An issue or change related to the picocli-codegen module labels Oct 21, 2018
@remkop remkop merged commit 98b7734 into remkop:master Oct 22, 2018
remkop added a commit that referenced this pull request Oct 22, 2018
@remkop remkop modified the milestones: 4.1, 3.8 Nov 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants