Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for enabling quote trimming via a system property #562

Merged
merged 1 commit into from
Dec 1, 2018
Merged

Allow for enabling quote trimming via a system property #562

merged 1 commit into from
Dec 1, 2018

Conversation

triceo
Copy link
Contributor

@triceo triceo commented Dec 1, 2018

The property is picocli.trimQuotes.

When set to true or when left empty, quote trimming will be enabled by default. Otherwise, the default is false. Regardless of the value of the property, the value can still be overriden through the usual API - therefore there is no break in backwards compatibility.

@codecov-io
Copy link

Codecov Report

Merging #562 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #562      +/-   ##
============================================
+ Coverage     89.13%   89.14%   +<.01%     
  Complexity      286      286              
============================================
  Files             4        4              
  Lines          3967     3970       +3     
  Branches        976      977       +1     
============================================
+ Hits           3536     3539       +3     
  Misses          212      212              
  Partials        219      219
Impacted Files Coverage Δ Complexity Δ
src/main/java/picocli/CommandLine.java 89.18% <100%> (ø) 161 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 950816e...277e2a9. Read the comment docs.

@triceo triceo changed the title Allow enabling quote trimming via a system property Allow for enabling quote trimming via a system property Dec 1, 2018
@remkop remkop merged commit 3e10d5b into remkop:master Dec 1, 2018
@remkop
Copy link
Owner

remkop commented Dec 1, 2018

Merged. Thanks for the PR!

@remkop remkop added this to the 3.8.1 milestone Dec 1, 2018
@triceo triceo deleted the sysprop branch December 1, 2018 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants