Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump JLine to 3.13.2 #888

Merged
merged 3 commits into from
Dec 1, 2019
Merged

Bump JLine to 3.13.2 #888

merged 3 commits into from
Dec 1, 2019

Conversation

mattirn
Copy link
Contributor

@mattirn mattirn commented Nov 30, 2019

Command parameter completion is still missing...
@remkop, if you can add some command parameters to example I can try to implement completers.

PS. top command is working ok... what you see is asciinema problem ;)

@codecov-io
Copy link

codecov-io commented Nov 30, 2019

Codecov Report

Merging #888 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #888   +/-   ##
=========================================
  Coverage     92.84%   92.84%           
  Complexity      388      388           
=========================================
  Files             2        2           
  Lines          5812     5812           
  Branches       1512     1512           
=========================================
  Hits           5396     5396           
  Misses          205      205           
  Partials        211      211

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 389e46f...eafc508. Read the comment docs.

@remkop remkop added theme: auto-completion An issue or change related to auto-completion type: enhancement ✨ theme: shell An issue or change related to interactive (JLine) applications labels Dec 1, 2019
@remkop
Copy link
Owner

remkop commented Dec 1, 2019

@mattirn I like the asciinema a lot! This looks like a very nice PR, thank you!

Can I ask you to also update the README for the picocli-shell-jline3 module?
It would especially be good to explain what the new PicocliCommands class does and how developers can use it to enhance their application.
Perhaps the example in the README should also use the new PicocliCommands class.

Again, thank you! This looks really nice!

@remkop
Copy link
Owner

remkop commented Dec 1, 2019

@mattirn I saw you pushed updates to the documentation, thank you!

I am happy to merge it as is, but I really liked the asciinema you created and I wondered if we could include those in the readme - if you are okay with that, that is...

What do you think?

@mattirn
Copy link
Contributor Author

mattirn commented Dec 1, 2019

I have already included the asciinema linked in this pull request in README. You are free to include also others if you like JLine demos :).

@remkop remkop merged commit 7469e42 into remkop:master Dec 1, 2019
remkop added a commit that referenced this pull request Dec 1, 2019
@remkop
Copy link
Owner

remkop commented Dec 1, 2019

Merged into master.
Also updated the release notes.
Thank you for the contribution. Very nice!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
theme: auto-completion An issue or change related to auto-completion theme: shell An issue or change related to interactive (JLine) applications type: doc 📘 type: enhancement ✨
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants