Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement .remoteignore.toml config file support and fix minor issues #40

Merged
merged 1 commit into from
Oct 8, 2020

Conversation

bzzzzzz
Copy link
Contributor

@bzzzzzz bzzzzzz commented Oct 8, 2020

This PR adds .remoteignore.toml file that can be used to define sync excludes and includes for workspace and is safe to commit in VCS (#37)
It also fixes a typo in include_vcs_ignore_patterns option name and introduces using of shlex to escape the shell command (#39)

Copy link
Collaborator

@shirshanka shirshanka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Sorry I didn't catch the typo earlier :)

@bzzzzzz bzzzzzz merged commit 28700a1 into master Oct 8, 2020
@bzzzzzz bzzzzzz deleted the remoteignore branch October 8, 2020 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants