Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pass inputProps to component in preview #430

Merged
merged 1 commit into from
Jun 6, 2021
Merged

Conversation

JonnyBurger
Copy link
Member

Previously you could only get it using getInputProps but that is not consistent with how it works during rendering. Fixes #428

@vercel
Copy link

vercel bot commented Jun 6, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.

remotion – ./

🔍 Inspect: https://vercel.com/jonnyburger/remotion/6cJBVE7jTgY2C3gPQ9L56JyM1Buf
✅ Preview: https://remotion-git-jonnyburger-issue428-jonnyburger.vercel.app

remotion-player-example – ./

🔍 Inspect: https://vercel.com/jonnyburger/remotion-player-example/ApooXadSwTTy4LV45LVqRNzZUeNr
✅ Preview: https://remotion-player-example-git-jonnyburger-issue428-jonnyburger.vercel.app

@JonnyBurger JonnyBurger enabled auto-merge (rebase) June 6, 2021 10:21
Copy link
Contributor

@Iamshankhadeep Iamshankhadeep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@JonnyBurger JonnyBurger merged commit 4e10aa1 into main Jun 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

—props doesn’t work in Preview Mode
2 participants