Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add template-empty to the template list #620

Merged
merged 1 commit into from
Oct 2, 2021

Conversation

aneeshrelan
Copy link

Implements #616

@aneeshrelan
Copy link
Author

@Iamshankhadeep @JonnyBurger I might need some help in transferring the repository. A simple transfer throws a permission error. The template is available at: template-empty if you want to take a look and provide feedback

@JonnyBurger
Copy link
Member

Thanks a lot! It looks 90% done :D Just a few requests:

  • We don't commit the lockfile to the templates, so it works with npm and yarn, so for this reason please remove package-lock.json.
  • Can you also remove express, @types/express dependencies as well as Dockerfile and .dockerignore. (this is the minimalistic template)
  • In .github/workflows/render-video.yml the two inputs should be removed as well, it's only used in the Hello World

Otherwise perfect! What permission error do you get when transferring the repo?

@aneeshrelan
Copy link
Author

Thank you for the feedback. Resolved all, please check :D

For the error, when I click on the "Transfer ownership" in the repo settings and mention the remotion-dev organisation. It throws an error saying "You don’t have the permission to create public repositories on remotion-dev". I might be missing something

@JonnyBurger
Copy link
Member

@aneeshrelan Ah ok, probably a GitHub thing. In that case, transfer it to JonnyBurger and then I'll transfer it again!

@aneeshrelan
Copy link
Author

@JonnyBurger Transferred. Please check

Copy link
Member

@JonnyBurger JonnyBurger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot! 🙌🏼

@JonnyBurger JonnyBurger merged commit de8bfd6 into remotion-dev:main Oct 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants