Float: Refactor bool == false into not function #623
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Incarnation-p-lee
commented
Jul 6, 2024
Incarnation-p-lee
commented
- Add new function not (bool) -> bool.
- Leverage not (bool) function in float lib.
* Add new function not (bool) -> bool. * Leverage not (bool) function in float lib. Signed-off-by: Pan Li <pan2.li@intel.com>
13 tasks
arichardson
reviewed
Jul 8, 2024
lib/float/common.sail
Outdated
| @@ -86,4 +86,13 @@ function float_decompose(op) = { | |||
| } | |||
| } | |||
|
|
|||
| val not : bool -> bool | |||
There was a problem hiding this comment.
There is already a not_bool function in flow.sail: https://github.com/rems-project/sail/blob/sail2/lib/flow.sail
sail-riscv has the following to add not():
// not_bool alias.
val not : forall ('p : Bool). bool('p) -> bool(not('p))
function not(b) = not_bool(b)
There was a problem hiding this comment.
Great! Looks we can alias this similar to sail-riscv, let me update it.
Signed-off-by: Pan Li <pan2.li@intel.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.