Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix noTemplate option of ComponentTestBed and post-test code execution of ServiceTestBed #48

Merged
merged 6 commits into from
Jan 29, 2024

Conversation

remscodes
Copy link
Owner

  • Fix noTemplate option of ComponentTestBed.
  • Make sure that the post-test code for ServiceTestBed is run after the end of the test (async or not).
  • Refactor error message.
  • Make RxBox unsubsribe() and complete() private.

@remscodes remscodes self-assigned this Jan 29, 2024
Copy link

codecov bot commented Jan 29, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (6f34097) 96.77% compared to head (168696d) 97.68%.

Files Patch % Lines
...ting-tools/src/lib/common/test-bed/jasmine-done.ts 71.42% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #48      +/-   ##
==========================================
+ Coverage   96.77%   97.68%   +0.90%     
==========================================
  Files          48       50       +2     
  Lines         248      259      +11     
  Branches       51       52       +1     
==========================================
+ Hits          240      253      +13     
+ Misses          8        6       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@remscodes remscodes merged commit f8bcf68 into main Jan 29, 2024
4 checks passed
@remscodes remscodes deleted the refactor branch January 29, 2024 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant