Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate http, injector and module utilities outside custom test beds #50

Merged
merged 2 commits into from
Jan 29, 2024

Conversation

remscodes
Copy link
Owner

  • Deprecate emitFakeSuccessResponse, emitFakeErrorResponse and expectHttpRequest.
  • Deprecate fromInjector.
  • Deprecate expectModuleToCreate.

@remscodes remscodes added the v3.x Deprecated stuffs to be remove in v3 label Jan 29, 2024
@remscodes remscodes self-assigned this Jan 29, 2024
Copy link

codecov bot commented Jan 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (90aa7f5) 98.14% compared to head (23b498d) 98.14%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #50   +/-   ##
=======================================
  Coverage   98.14%   98.14%           
=======================================
  Files          50       50           
  Lines         270      270           
  Branches       58       58           
=======================================
  Hits          265      265           
  Misses          5        5           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@remscodes remscodes merged commit 5767c05 into main Jan 29, 2024
4 checks passed
@remscodes remscodes deleted the deprecate branch January 29, 2024 22:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v3.x Deprecated stuffs to be remove in v3
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant