Adds support for Time.zone via ActiveSupport::TimeWithZone #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ah, I just saw your comment on not wanting to introduce a dependency on ActiveSupport. Sorry about that! |
|
See bbd6e89 for a solution. |
|
Ah, awesome. Thanks! |
ombr
pushed a commit
to ombr/exifr
that referenced
this pull request
Jun 7, 2021
fix: Firefox > 77 not checked for auto rotation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because EXIF does not include timezone information, the user should be able to set what timezone the times are parsed in. ActiveSupport has a nice way to do this: