-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Required: browser extensions #6
Comments
I am having a go at this using the crossrider site. It is pretty simple to use and creates a extension for Internet Explorer 7+, Firefox 3.5+ and Chrome. Might have something for you tomorrow. |
How about a bookmarklet? Could work with a JSONP response. |
@remy Can you add a JSONP response to this. Should be a simple thing to check whether there is a callback in the url. |
Yep, easy. Sent from my iPhone On 11 Feb 2012, at 11:31, Sam Bennett reply@reply.github.com wrote:
|
Sweet, that should mean my multi browser extension should be ready when you are. Actually I change the |
Have you just broke this? Every site seems to be passing. |
I think so. I was working last night on using message queues and workers to get the work done, but I suspect it's gone a little tits up. In fact now, I'm not getting anything. I've got some scaling issues I need to look at - and probably need to go a knocking on hosting company doors :) I'll see if I can't sort it shortly. |
Doesn't seem to load the page no more :( If I had a decent host I might run a test version so I can keep working. |
It's back up for the time being. Given the few hours I've worked on it, there's some exceptions I'm hitting (like invalid urls, etc). If you're testing - best to test with static responders like:
|
With JSONP support, I'll add CORS which will be better as you'll be able to handle timeouts, etc much more cleanly. |
@sambenne sorry, I should have added - you can host this locally for testing - clone the project, install Node.js then in the project directory run |
Based on the static I can get the JSON to work and it changes the icon from red to green on page load. I am going to get it to show the errors in a popup on a click event. |
Here is the first test. On the page load it will check the site http://jsbin.com/erigos/3/js but on click it will check http://jsbin.com/erigos/4/js so you can see how it looks both ways. I am going to try it on FF. |
@sambenne extension looks nice as a starter (only quickly checked it out). I saw your tweet too - though I fear you've wasted a bit of your time! The "check your site" part of things is handled entirely by csslint.net. The error when you're doing the .json call is only the first error (and though I've not updated docs) it will only be the first error to basic reduce the work of the server when doing a single yes/no test. So in a way it's not that useful (and I'd probably not show in the icon at all). Is there source available for the extension at all? Might be useful to let others have a peek around to learn from it. Couple of bits of feedback, no doubt you've already considered yourself:
I'm also going to update the readme so it's exactly clear what this tool/service does! :) :: edit :: Sorry - just re-read - you said it's hitting the static examples so I could see what it looks like - so it's not hooked up to live - that's cool1 |
Ah that image on twitter was actually using your API that I used for the extension. So its data was based of what gets returned. Was thinking the extension could take you to a page that had a more detailed explanation for you. When I get on my Laptop I will put the code on my github and link you to it. |
Using the green/red idea for the pass or fail, make a request to
And the JSON returned contains:
(or false) - which will drive the icon.
Can this be done for all browsers?
The text was updated successfully, but these errors were encountered: