Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Report is not generated when all class tests have @ignore #242

Open
AnthonyTonda opened this issue Jan 21, 2023 · 7 comments
Open

Report is not generated when all class tests have @ignore #242

AnthonyTonda opened this issue Jan 21, 2023 · 7 comments

Comments

@AnthonyTonda
Copy link

Given all classes have @ignore
When I run these classes
Then spock report generates no report at all
But I would expect to have the generated report where I see the list of tests didn’t run

Spock Version: 1.3-groovy-2.4
Spock Report Version: 1.2.7

@renatoathaydes
Copy link
Owner

I agree, and am surprised that's the case! If you would like to submit a pull request, this should be easy to fix.

Otherwise, I may have a look within a couple of months, given I am too busy at the moment with other things.

@renatoathaydes renatoathaydes changed the title Is it by designed that report is not generated when all class tests have @ignore ? Report is not generated when all class tests have @ignore Jan 23, 2023
@AnthonyTonda
Copy link
Author

Hi Renato, will try to raise a PR ;) to which branch I should select for raising the PR ? to dev ?

@renatoathaydes
Copy link
Owner

Yes, dev, I've just updated that!

@renatoathaydes
Copy link
Owner

I tried to fix this issue, but it seems impossible because Spock is not even calling spock-reports' extension when the spec is fully ignored.

That looks like a bug in Spock, because extensions have a method, which I've implemented, for this case:

    @Override
    void specSkipped( SpecInfo spec )

@AnthonyTonda
Copy link
Author

Thank for looking at it.

@renatoathaydes
Copy link
Owner

Reported to Spock: spockframework/spock#1662

@renatoathaydes
Copy link
Owner

The bug is fixed on the Spock side, just waiting for the PR to be merged and the fix released.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants