Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade PageCrypt, remove Node v19 restriction #3

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Upgrade PageCrypt, remove Node v19 restriction #3

wants to merge 1 commit into from

Conversation

metonym
Copy link

@metonym metonym commented Dec 27, 2022

Previously, this example did not work with Node version 19 (#1). #2 specified engines.node to >=16 <19.

PageCrypt version 6.0.0 is now compatible with Node 19.

This PR loosens the engines.node restriction and upgrades the pagecrypt dependency.

I tested this with both Node 16 and 19:

nvm use 19
PASSWORD=1234 yarn build
# builds successfully

nvm use 16
PASSWORD=1234 yarn build
# builds successfully

@metonym metonym requested review from StephenBarlow and removed request for eropple September 26, 2023 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BigAlRender BigAlRender Awaiting requested review from BigAlRender

@StephenBarlow StephenBarlow Awaiting requested review from StephenBarlow

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@metonym