-
Notifications
You must be signed in to change notification settings - Fork 312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wrap Handlebars in a template adapter, Part II #56
Conversation
Conflicts: package.json server/viewEngine.coffee shared/app.coffee shared/base/view.coffee shared/globals.coffee
This reverts commit d70f11d.
I think we can move forward without solving packaging. Seems like another big open question. Would be nice to keep both discussions moving. @spikebrehm, you okay with requiring a few extra lines in project build files while #35 gets sorted out, or would you rather wait and release a polished build interface? |
@hurrymaplelad so sorry for waiting FOREVER to get this merged in! I was finally able to give it a test locally, and it works beautifully. Will merge now. |
I just first want to make sure that it's still easy to add custom Handlebars helpers in |
Wrap Handlebars in a template adapter, Part II
👍 |
Wrap Handlebars in a template adapter, Part II
This is an evolution of #19. Unfortunately had to open a new PR because I couldn't push commits to @hurrymaplelad's branch (or my Git-fu isn't that strong).
I think this is all ready to go. It uses airbnb/rendr-handlebars (forked from @hurrymaplelad). I've simplified its API so that instead of:
we have:
Before we merge into
airbnb/rendr
, we need to figure out how to properly package the client-side files for an app, which I'm proof-of-concepting withairbnb/rendr-app-template
(view the template-adapter branch). It works fine server-side, however because we're using Stitch to package for the client, we'll have to do something like use Grunt+Browserify to compile a client-sidedist
file, because Stitch doesn't automatically package up the module graph. This is another reason to switch to Browserify from Stitch, but that may be a lot more work.