Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

This fixes an issue with non-ASCII characters included in the CSS files. #16

Closed
wants to merge 3 commits into from
Closed

This fixes an issue with non-ASCII characters included in the CSS files. #16

wants to merge 3 commits into from

Conversation

jezdez
Copy link

@jezdez jezdez commented Jan 18, 2012

No description provided.

Philipp Wassibauer and others added 2 commits September 29, 2011 16:59
@jezdez
Copy link
Author

jezdez commented Jun 21, 2012

Any news on this one?

@zz85 zz85 mentioned this pull request Oct 8, 2012
Closed
@rennat
Copy link
Owner

rennat commented Feb 23, 2013

In my testing environment:

$ python --version
Python 2.7.2

$ pip freeze
BeautifulSoup==3.2.0
Jinja2==2.6
Pygments==1.4
Sphinx==1.0.7
cssutils==0.9.8a3
docutils==0.8
wsgiref==0.1.2

$ python tests.py 
.......F.FFF........F.FF......
======================================================================
FAIL: test_08_fromURL (__main__.Basic)
Test 'fromURL' constructor
----------------------------------------------------------------------
Traceback (most recent call last):
  File "tests.py", line 72, in test_08_fromURL
    self.assertEqual(p.style_string, "p {color: #999}")
AssertionError: u'' != 'p {color: #999}'

======================================================================
FAIL: test_double_comment (__main__.BeautifulSoupBugs)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "tests.py", line 211, in test_double_comment
    self.assertNotIn("<!--<!--", output)
AssertionError: '<!--<!--' unexpectedly found in u'<!--<!-- comment -->-->'

======================================================================
FAIL: test_double_comment_and_unicode (__main__.BeautifulSoupBugs)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "tests.py", line 217, in test_double_comment_and_unicode
    self.assertNotIn("<!--<!--", output)
AssertionError: '<!--<!--' unexpectedly found in u'<!--<!-- comment \xe4\xe4 -->-->'

======================================================================
FAIL: test_double_doctype (__main__.BeautifulSoupBugs)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "tests.py", line 206, in test_double_doctype
    self.assertNotIn("<!<!", output)
AssertionError: '<!<!' unexpectedly found in u'<!<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN"\n"http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">>'

======================================================================
FAIL: test_adjacent_selector (__main__.ComplexSelectors)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "tests.py", line 254, in test_adjacent_selector
    self.assertEqual(output, expected)
AssertionError: u'<h1>Hello World!</h1><h2>How are you?</h2>' != u'<h1>Hello World!</h1><h2 style="color: red">How are you?</h2>'
- <h1>Hello World!</h1><h2>How are you?</h2>
+ <h1>Hello World!</h1><h2 style="color: red">How are you?</h2>
?                         +++++++++++++++++++


======================================================================
FAIL: test_child_selector (__main__.ComplexSelectors)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "tests.py", line 247, in test_child_selector
    self.assertEqual(output, expected)
AssertionError: u'<h1><span>Hello World!</span></h1>' != u'<h1><span style="color: red">Hello World!</span></h1>'
- <h1><span>Hello World!</span></h1>
+ <h1><span style="color: red">Hello World!</span></h1>
?          +++++++++++++++++++


======================================================================
FAIL: test_combination_selector (__main__.ComplexSelectors)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "tests.py", line 233, in test_combination_selector
    self.assertEqual(output, expected)
AssertionError: u'<h1 id="a" class="b">Hello World!</h1>' != u'<h1 id="a" class="b" style="color: red">Hello World!</h1>'
- <h1 id="a" class="b">Hello World!</h1>
+ <h1 id="a" class="b" style="color: red">Hello World!</h1>
?                     +++++++++++++++++++


----------------------------------------------------------------------
Ran 30 tests in 0.359s

FAILED (failures=7)

My main concern are the beautiful soup bug tests.

@rennat
Copy link
Owner

rennat commented Apr 26, 2013

These changes are covered in a previous pull request that has been merged.

@rennat rennat closed this Apr 26, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jezdez @rennat