Skip to content

Commit

Permalink
More links
Browse files Browse the repository at this point in the history
  • Loading branch information
Sergei Zharinov committed Apr 20, 2021
1 parent 16fbbca commit ae348f6
Show file tree
Hide file tree
Showing 9 changed files with 6 additions and 13 deletions.
4 changes: 2 additions & 2 deletions lib/datasource/docker/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,8 @@ import * as dockerVersioning from '../../versioning/docker';
import type { GetReleasesConfig, ReleaseResult } from '../types';
import { Image, ImageList, MediaType } from './types';

// TODO: add got typings when available
// TODO: replace www-authenticate with https://www.npmjs.com/package/auth-header ?
// TODO: https://github.com/renovatebot/renovate/issues/9646
// TODO: https://github.com/renovatebot/renovate/issues/9645

export const id = 'docker';
export const customRegistrySupport = true;
Expand Down
2 changes: 1 addition & 1 deletion lib/manager/pip_setup/index.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@ describe(getName(__filename), () => {
binarySource: BinarySource.Docker,
})
).toMatchSnapshot();
expect(execSnapshots).toHaveLength(1); // TODO: figure out volume arguments in Windows
expect(execSnapshots).toHaveLength(1); // TODO: https://github.com/renovatebot/renovate/issues/9617
});

it('returns no deps', async () => {
Expand Down
1 change: 0 additions & 1 deletion lib/manager/travis/package.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@ jest.mock('../../datasource');

describe(getName(__filename), () => {
describe('getPackageUpdates', () => {
// TODO: should be `PackageUpdateConfig`
let config: any;
const RealDate = Date;

Expand Down
1 change: 0 additions & 1 deletion lib/manager/travis/package.ts
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,6 @@ export async function getPackageUpdates(
}
newValue.sort((a, b) => a - b);

// TODO: `config.currentValue` is a string!
(config.currentValue as any).sort((a, b) => a - b);
if (dequal(config.currentValue, newValue)) {
return { updates: [] };
Expand Down
4 changes: 0 additions & 4 deletions lib/manager/travis/update.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@ const content = readFileSync(
describe(getName(__filename), () => {
describe('updateDependency', () => {
it('updates values', () => {
// TODO: should be `Upgrade`
const upgrade: any = {
currentValue: ['8', '6', '4'],
newValue: '6,8',
Expand All @@ -20,7 +19,6 @@ describe(getName(__filename), () => {
expect(res).toMatchSnapshot();
});
it('falls back to 2 spaces', () => {
// TODO: should be `Upgrade`
const upgrade: any = {
currentValue: [8, 6, 4],
newValue: '6,8',
Expand All @@ -32,7 +30,6 @@ describe(getName(__filename), () => {
expect(res).toMatchSnapshot();
});
it('uses double quotes', () => {
// TODO: should be `Upgrade`
const upgrade: any = {
currentValue: ['6'],
newValue: '6,8',
Expand All @@ -44,7 +41,6 @@ describe(getName(__filename), () => {
expect(res).toMatchSnapshot();
});
it('returns null if error', () => {
// TODO: should be `Upgrade`
const upgrade: any = {
currentValue: [8, 6, 4],
newValue: 6,
Expand Down
1 change: 0 additions & 1 deletion lib/manager/travis/update.ts
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@ export function updateDependency({
quote = '';
}
let newString = `node_js:\n`;
// TODO: `newValue` is a string!
upgrade.newValue.split(',').forEach((version) => {
newString += `${indent}- ${quote}${version}${quote}\n`;
});
Expand Down
2 changes: 1 addition & 1 deletion lib/platform/index.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ describe(getName(__filename), () => {

it('validates', () => {
function validate(module: Platform, name: string): boolean {
// TODO: test required api
// TODO: https://github.com/renovatebot/renovate/issues/9650
if (!module.initPlatform) {
throw Error(`Missing api on ${name}`);
}
Expand Down
2 changes: 1 addition & 1 deletion lib/util/http/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ import { applyHostRules } from './host-rules';
import { getQueue } from './queue';
import { GotOptions, RequestStats } from './types';

// TODO: refactor code to remove this
// TODO: https://github.com/renovatebot/renovate/issues/9651
import './legacy';

export * from './types';
Expand Down
2 changes: 1 addition & 1 deletion lib/util/http/legacy.ts
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
import { parseUrl } from '../url';
import { HttpError } from './types';

// TODO: remove when code is refactored
// TODO: https://github.com/renovatebot/renovate/issues/9651

Object.defineProperty(HttpError.prototype, 'statusCode', {
get: function statusCode(this: HttpError) {
Expand Down

0 comments on commit ae348f6

Please sign in to comment.