Skip to content

feat(pr): display latest pending update in upgrades table #13768

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 24, 2022

Conversation

rarkins
Copy link
Collaborator

@rarkins rarkins commented Jan 24, 2022

Changes:

Adds new "Pending" column to upgrades, for use when internalChecksFilter filtering is active.

Context:

Today there is no visibility of a pending update.

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please tick one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@rarkins rarkins requested a review from viceice January 24, 2022 09:29
@rarkins
Copy link
Collaborator Author

rarkins commented Jan 24, 2022

At first I attempted to create a checkbox for "force pending updates" for the PR (similar to rebase/retry) but found that it's going to be quite complicated due to the need to update newVersion, newValue, displayTo, and perhaps more.

Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise LGTM

@rarkins rarkins requested a review from viceice January 24, 2022 10:56
@rarkins rarkins enabled auto-merge (squash) January 24, 2022 10:56
@rarkins rarkins merged commit 2e35968 into main Jan 24, 2022
@rarkins rarkins deleted the feat/display-pending branch January 24, 2022 11:09
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 31.50.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

ademar59 pushed a commit to ademar59/renovate that referenced this pull request Jan 24, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants