Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(util/exec): Fix strict null errors #12909

Merged
merged 9 commits into from
Dec 10, 2021
Merged

refactor(util/exec): Fix strict null errors #12909

merged 9 commits into from
Dec 10, 2021

Conversation

zharinov
Copy link
Collaborator

@zharinov zharinov commented Dec 1, 2021 •
edited
Loading

Changes:

  • Fix null errors inside util/exec directory
  • Exc lude files with transitive errors

Context:

  • Ref: #7154

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please tick one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

viceice
viceice reviewed Dec 1, 2021
View reviewed changes
lib/util/exec/index.ts Outdated Show resolved Hide resolved
lib/util/exec/docker/index.ts Outdated Show resolved Hide resolved
lib/util/exec/index.ts Outdated Show resolved Hide resolved
lib/util/exec/index.ts Outdated Show resolved Hide resolved
lib/util/exec/index.ts Outdated Show resolved Hide resolved
lib/util/exec/index.ts Outdated Show resolved Hide resolved
lib/util/exec/index.ts Show resolved Hide resolved
@rarkins
Copy link
Collaborator

rarkins commented Dec 8, 2021

@zharinov needs de-conflicting plus suggestions resolved

@rarkins rarkins marked this pull request as draft December 8, 2021 12:13
@zharinov zharinov marked this pull request as ready for review December 8, 2021 17:41
@zharinov zharinov requested a review from viceice December 8, 2021 18:29
@rarkins rarkins requested a review from viceice December 10, 2021 13:09
@viceice viceice merged commit 995df4d into renovatebot:main Dec 10, 2021
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 30.2.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@viceice viceice viceice approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zharinov @rarkins @renovate-release @viceice