-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(config): Make ignore comments configurable #12917
feat(config): Make ignore comments configurable #12917
Conversation
When a PR is closed, Renovate posts a comment to let users know that future updates will be ignored. This change makes contents of that comment configurable via the config file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm wondering if it would be better to use an object for this config, like we do with product links:
renovate/lib/config/options/index.ts
Lines 126 to 141 in e8e99ef
{ | |
name: 'productLinks', | |
description: 'Links which are embedded within PRs, issues, etc.', | |
type: 'object', | |
globalOnly: true, | |
mergeable: true, | |
default: { | |
documentation: 'https://docs.renovatebot.com/', | |
help: 'https://github.com/renovatebot/renovate/discussions', | |
homepage: 'https://github.com/renovatebot/renovate', | |
}, | |
additionalProperties: { | |
type: 'string', | |
format: 'uri', | |
}, | |
}, |
It could be called something like userStrings
and then have fields like ignoreDigest
, ignoreMajor
, etc.
Thanks for the review!
Makes total sense. Fixed in a964e86. |
🎉 This PR is included in version 29.36.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Changes:
When a PR is closed, Renovate posts a comment to let users know
that future updates will be ignored. This change makes contents of that
comment configurable via the config file.
Documentation (please check one with an [x])
How I've tested my work (please tick one)
I have verified these changes via: