Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(migrations): extend abstract migration #12963

Merged
merged 7 commits into from
Dec 11, 2021
Merged

refactor(migrations): extend abstract migration #12963

merged 7 commits into from
Dec 11, 2021

Conversation

pret-a-porter
Copy link
Contributor

Changes:

  1. Extend AbstractMigration
  2. Align MigrationsService and existing migrations by new changes

Context:

  1. Migrate inline with same sort  #11459
  2. Part of Refactor/migrations #12957

Documentation

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

viceice
viceice reviewed Dec 9, 2021
View reviewed changes
lib/config/migration.ts Show resolved Hide resolved
lib/config/migrations/base/remove-property-migration.ts Outdated Show resolved Hide resolved
lib/config/migrations/migrations-service.ts Outdated Show resolved Hide resolved
lib/config/migrations/types.ts Outdated Show resolved Hide resolved
@viceice viceice enabled auto-merge (squash) December 11, 2021 13:48
@viceice viceice merged commit a4249f9 into renovatebot:main Dec 11, 2021
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 30.3.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 12, 2022
@pret-a-porter pret-a-porter deleted the refactor/extend_abstract_migration branch January 23, 2022 20:37
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@viceice viceice viceice approved these changes

@JamieMagee JamieMagee Awaiting requested review from JamieMagee

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pret-a-porter @renovate-release @viceice