Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(automerge): don't reassign failing PRs if assignAutomerge=true #14065

Merged
merged 1 commit into from
Feb 7, 2022
Merged

fix(automerge): don't reassign failing PRs if assignAutomerge=true #14065

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions lib/workers/pr/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -358,6 +358,7 @@ export async function ensurePr(
!existingPr.hasAssignees &&
!existingPr.hasReviewers &&
config.automerge &&
!config.assignAutomerge &&
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't work for automerge branch? 🤔

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Edge of an edge case, good catch :)

(await getBranchStatus()) === BranchStatus.red
) {
logger.debug(`Setting assignees and reviewers as status checks failed`);
Expand Down