-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(versioning/debian): Debian codenames support #14881
feat(versioning/debian): Debian codenames support #14881
Conversation
Example run on real repo. @JamieMagee @viceice |
d811e97
to
04a5478
Compare
I think the main thing we need to know is "what is the stable release of Debian"? To us both testing and unstable are considered unstable. Ideally there was a better way of getting that info. Does Debian have a "schedule" anywhere where they document intent to promote a certain version to stable in the future? E.g. like node.js does |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also please Split the Ubuntu refactoring from this new feature to a separate PR.
There's not a clean API or schedule of sorts. The reference for most of this info is going to be these pages: They give future EOL dates to the month. @Gabriel-Ladzaretti I think the wiki might be a slightly better option? But not by much. Equally, they change every 2 years 🤷 The special cases we need to handle are:
|
Actually, with a bit more digging, this is the source for |
@JamieMagee @viceice @rarkins |
I see this is listed in your top post, is still still blocking us? |
Not the cleanest way of doing things, but i was working on both PR simultaneously as the refactor came out to be because of this one. so i am cherry picking changes back and forth. |
You mean like |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please extract the refactorings from this PR, so we can merge those first.
…-Ladzaretti/renovate into debian-codenames-support � Conflicts: � lib/modules/versioning/ubuntu/index.ts
- moved all time/date handling into distro.ts - date freeze for ubuntu/debian/distro unit tests
# Conflicts: # lib/modules/versioning/distro.ts # lib/modules/versioning/ubuntu/index.ts
- merge distro refactor
- extract private properties
- cr changes
- cr changes
- cr changes
🎉 This PR is included in version 32.63.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Changes
Added dedicated versioning for
Debian
by extendingdockerVersioningApi
.Supports debian codenames.
#14601 (comment)
Context
Documentation (please check one with an [x])
How I've tested my work (please tick one)
I have verified these changes via: