Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(poetry): normalize package name #19807

Merged
merged 12 commits into from
Jan 14, 2023

Conversation

dave-powell-kensho
Copy link
Contributor

Changes

(poetry) Normalize project names read from pyproject.toml in adherence with PEP 503 and PEP 621. poetry stores normalized project names in poetry.lock files, so without this normalization on the data read from the pyproject.toml files, there may be a misalignment leading to renovate not being able to update the lockfile.

For example, a valid entry in pyproject.toml may read as prometheus_client, but is represented in the lockfile as prometheus-client.

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

lib/modules/manager/poetry/extract.ts Outdated Show resolved Hide resolved
lib/modules/manager/poetry/extract.ts Outdated Show resolved Hide resolved
rarkins
rarkins previously approved these changes Jan 13, 2023
@rarkins rarkins requested a review from viceice January 13, 2023 15:28
rarkins
rarkins previously approved these changes Jan 13, 2023
viceice
viceice previously approved these changes Jan 13, 2023
@rarkins rarkins enabled auto-merge (squash) January 14, 2023 06:08
@rarkins rarkins merged commit 74e592c into renovatebot:main Jan 14, 2023
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 34.102.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@dave-powell-kensho dave-powell-kensho deleted the poetry-pep503-normalize branch January 17, 2023 15:16
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants