-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(poetry): normalize package name #19807
Merged
rarkins
merged 12 commits into
renovatebot:main
from
dave-powell-kensho:poetry-pep503-normalize
Jan 14, 2023
Merged
fix(poetry): normalize package name #19807
rarkins
merged 12 commits into
renovatebot:main
from
dave-powell-kensho:poetry-pep503-normalize
Jan 14, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rarkins
reviewed
Jan 12, 2023
viceice
reviewed
Jan 12, 2023
rarkins
reviewed
Jan 13, 2023
rarkins
previously approved these changes
Jan 13, 2023
rarkins
previously approved these changes
Jan 13, 2023
viceice
previously approved these changes
Jan 13, 2023
rarkins
approved these changes
Jan 14, 2023
🎉 This PR is included in version 34.102.1 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
(poetry) Normalize project names read from pyproject.toml in adherence with PEP 503 and PEP 621. poetry stores normalized project names in poetry.lock files, so without this normalization on the data read from the pyproject.toml files, there may be a misalignment leading to renovate not being able to update the lockfile.
For example, a valid entry in pyproject.toml may read as
prometheus_client
, but is represented in the lockfile asprometheus-client
.Documentation (please check one with an [x])
How I've tested my work (please select one)
I have verified these changes via: