Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(manager/poetry): Support tag as git-dependency on github #21949

Merged
merged 7 commits into from
May 3, 2023

Conversation

yetanotherion
Copy link
Contributor

@yetanotherion yetanotherion commented May 3, 2023

Changes

Parse git dependencies like

{git = "https://github.com/tiangolo/fastapi.git", tag="1.2.3"}

or

{git = "git@github.com:tiangolo/fastapi.git", tag="1.2.3"}

and support them as github-tags datasources.

Context

GitHub Packages currently lacks support for PyPI repositories. As an alternative, some companies opt to use git-dependencies for hosting internal dependencies rather than installing third-party solutions such as artifactory or Google’s Artifact Registry. This pull request adds support for specific use cases that rely on git tags, as discussed in issue #21848.

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

Parse git dependencies like
{git = "https://github.com/tiangolo/fastapi.git", tag="1.2.3"}
or
{git = "git@github.com:tiangolo/fastapi.git", tag="1.2.3"}

and support them as github-tabs datasources.
@yetanotherion yetanotherion changed the title feat(poetry) Support tag as git-dependency on github feat(poetry): Support tag as git-dependency on github May 3, 2023
@viceice
Copy link
Member

viceice commented May 3, 2023

please correctly fill the PR template

lib/modules/manager/poetry/extract.ts Show resolved Hide resolved
lib/modules/manager/poetry/extract.ts Outdated Show resolved Hide resolved
lib/modules/manager/poetry/extract.ts Outdated Show resolved Hide resolved
lib/modules/manager/poetry/extract.ts Outdated Show resolved Hide resolved
lib/modules/manager/poetry/extract.ts Outdated Show resolved Hide resolved
lib/modules/manager/poetry/extract.ts Outdated Show resolved Hide resolved
@viceice viceice changed the title feat(poetry): Support tag as git-dependency on github feat(manager/poetry): Support tag as git-dependency on github May 3, 2023
@yetanotherion yetanotherion requested a review from viceice May 3, 2023 12:16
@yetanotherion yetanotherion requested a review from rarkins May 3, 2023 12:44
@yetanotherion yetanotherion requested a review from viceice May 3, 2023 15:06
@yetanotherion
Copy link
Contributor Author

yetanotherion commented May 3, 2023

Thanks viceice! If that's fine with you, I'll wait for rarkins's approval before merging.

@rarkins rarkins added this pull request to the merge queue May 3, 2023
Merged via the queue into renovatebot:main with commit 97c3ae9 May 3, 2023
@yetanotherion
Copy link
Contributor Author

Thanks a lot rarkins!

@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 35.70.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@yetanotherion
Copy link
Contributor Author

yetanotherion commented May 4, 2023

rarkins, viceci, just wanted to congratulate you on the process put in place in renovate.

Everything is so self explanatory that I don't even have to ask when the PR will be released:

  • I have an automated comment that tells me so
  • With the info in the releases of the related github-action, I can conclude that this feature will be available in the coming days in the github-action too.

So far, contributing to renovate has been the best experience I ever had working in an open source project 👏 👏 👏, thank you!

@gnuletik
Copy link

gnuletik commented May 30, 2023

Hi, thanks for this PR!

In our projects, this does not seems to work on tags starting with a v prefix (e.g. v1.2.3).
We get the following error: WARN: Unexpected range error.

This seems to be a quite common behavior: https://semver.org/#is-v123-a-semantic-version

Is it an intended behavior?

Thanks!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants