-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(presets): split datatables.net grouping #23841
feat(presets): split datatables.net grouping #23841
Conversation
I'm not sure why the coverage dropped. 🤔 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we normally group only when they are published together with same version or they need to be grouped because of peer dependency requirements
Summary, DataTables are composed of a base component,
In summary, targeting |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see comment 🤗
🎉 This PR is included in version 36.44.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Changes
Tweak #23411 to be more specific as all datatables.net packages aren't always the same.
Project where all presets works: https://github.com/MindTooth/renovate-datatables.net-test/pulls
Context
I've had this in the back of my head for some time since my first pull request. And I wanted to improve it.
Why all the monorepo rules, are because that the individual packages (
datatables.net-buttons
) are combined with an additional style scheme (datatables.net-buttons-bs4
) e.g. Bootstrap 4, Bulma, etc.Documentation (please check one with an [x])
How I've tested my work (please select one)
I have verified these changes via: