Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(presets): split datatables.net grouping #23841

Merged
merged 3 commits into from
Aug 14, 2023

Conversation

MindTooth
Copy link
Contributor

Changes

Tweak #23411 to be more specific as all datatables.net packages aren't always the same.

Project where all presets works: https://github.com/MindTooth/renovate-datatables.net-test/pulls

Context

I've had this in the back of my head for some time since my first pull request. And I wanted to improve it.

Why all the monorepo rules, are because that the individual packages (datatables.net-buttons) are combined with an additional style scheme (datatables.net-buttons-bs4) e.g. Bootstrap 4, Bulma, etc.

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@MindTooth
Copy link
Contributor Author

I'm not sure why the coverage dropped. 🤔

Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we normally group only when they are published together with same version or they need to be grouped because of peer dependency requirements

lib/config/presets/internal/monorepo.ts Outdated Show resolved Hide resolved
lib/config/presets/internal/monorepo.ts Outdated Show resolved Hide resolved
@MindTooth
Copy link
Contributor Author

Summary, DataTables are composed of a base component, datatables.net(-bulma|bs4|dt)?, where e.g. -dt is their own styling. And individual plugins, datatables.net-scroller(-bulma|bs4|dt)?, where scroller is a plugin.

  • The all have unique sourceUrls.
  • They are all individually released together, base component is one, each plugin is another. Each component/plugin has their own version. In total, 8 packages share their release version.
  • In total targeting sourceUrl, is (8 * 14 = ) 112 lines
  • Almost always, will the user have at least the base component/plugin and an accompanying style ((-bulma|bs4|dt)?).

In summary, targeting sourceUrl will create many more lines. Just say so, and it will be done. 👍🏻

@MindTooth MindTooth requested a review from viceice August 13, 2023 10:42
Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see comment 🤗

@MindTooth MindTooth requested a review from viceice August 14, 2023 11:17
@viceice viceice changed the title refactor(presets): tweak datatables.net preset feat(presets): split datatables.net grouping Aug 14, 2023
@viceice viceice enabled auto-merge August 14, 2023 20:14
@viceice viceice added this pull request to the merge queue Aug 14, 2023
Merged via the queue into renovatebot:main with commit 03cb407 Aug 14, 2023
33 of 34 checks passed
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 36.44.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 14, 2023
@MindTooth MindTooth deleted the refactor/datatables_pkg_cleanup branch January 2, 2024 16:07
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants