Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(poetry): Provide better feedback for negation in the ranges #27193

Merged

Conversation

zharinov
Copy link
Collaborator

@zharinov zharinov commented Feb 9, 2024

Changes

  • poetry2npm and npm2poetry don't provide 1:1 match, because npm isn't expressive enough: it doesn't have negations

This PR provides some basic error handling for such cases.

Context

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@zharinov zharinov requested a review from rarkins February 9, 2024 16:32
@zharinov zharinov requested a review from viceice February 9, 2024 16:48
@secustor secustor added this pull request to the merge queue Feb 9, 2024
Merged via the queue into renovatebot:main with commit a62cfa0 Feb 9, 2024
36 checks passed
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 37.181.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

not7cd pushed a commit to uni-intelligence/renovate that referenced this pull request Feb 13, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Invalid comparator in poetry (!=3.0.)
3 participants