-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: use renovate/yarn as base image #4710
Conversation
relates to #4708 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think our CI actually tests building so we need to test this manually too
Dockerfile
Outdated
# required for install | ||
USER root | ||
|
||
RUN chown -R ubuntu:ubuntu /usr/src/app/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure this achieves anything here, unless we built renovate/yarn badly?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe we no longer need to write to this path?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK let's remove this section and see if everything is still fine
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have tested it locally against gitlab with docker and yarn manger
Dockerfile
Outdated
# required for install | ||
USER root | ||
|
||
RUN chown -R ubuntu:ubuntu /usr/src/app/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe we no longer need to write to this path?
f111189
to
ef3f903
Compare
Eventually - maybe v21 - I want to stop bundling npm, yarn and pnpm with Renovate (i.e. remove them as npm dependencies). Until then, we are installing npm and yarn as part of "yarn install" anyway so I'm not sure if we're saving much versus using renovate/node as our base image for publishing instead? |
We do not save space for now, but we save some build time and both images have the same base. And after this it is mode easy to migrate to node v12, because we only need to update base image When installing nodejs we always have npm installed, bcause it is packaged in nodejs. |
How would it be worse though if the final image was based off renovate/node instead of renovate/yarn? renovate/node should be a subset of renovate/yarn, and we don't run any |
🤔 We can use the |
If we use different base images we have to make sure, that both have the same node version. also yarn only add 2mb (compressed) to the image |
Ok fine, keep as is |
So merge to v20? |
|
||
USER root | ||
|
||
# Python 2 and make are required to build node-re2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't we be on python 3 now?
This pr uses
renovate/yarn
as base image.So i removed node, npm and yarn.
I also adapted the multistage build to match the slim image