Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/channel tests #75

Merged
merged 5 commits into from
Mar 15, 2021
Merged

Fix/channel tests #75

merged 5 commits into from
Mar 15, 2021

Conversation

loongy
Copy link
Contributor

@loongy loongy commented Mar 12, 2021

This PR makes several fixes for the channels.

  1. It removes the ability to do foreground draining on replaced connections. This was causing sporadic failures in tests, because TCP connections can get themselves into "half closed" states. We also do not actually use this feature.
  2. Draining readers did not respect sync messages. Now it does.
  3. Readers could get blocked on decoding from the underlying connection if the connection was replaced at that same moment. This is now handled correctly, and blocking no longer occurs.

@loongy loongy requested a review from tok-kkk as a code owner March 12, 2021 03:49
@loongy loongy changed the base branch from master to experiment/functional March 12, 2021 03:49
ross-pure
ross-pure approved these changes Mar 15, 2021
View reviewed changes
Copy link
Member

@ross-pure ross-pure left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with one small suggestion requested.

channel/channel_test.go Outdated Show resolved Hide resolved
@loongy @ross-pure
Update channel/channel_test.go
f9785e2 
Co-authored-by: ross-pure <32352822+ross-pure@users.noreply.github.com>
@loongy loongy merged commit 664c433 into experiment/functional Mar 15, 2021
@loongy loongy deleted the fix/channel-tests branch March 15, 2021 00:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ross-pure ross-pure ross-pure approved these changes

@tok-kkk tok-kkk Awaiting requested review from tok-kkk

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@loongy @ross-pure