Speed up allocateBranchIsland #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not a fan of early returns in the general case, but I'll let this one slide since the rest of this looks so good :) |
rentzsch
added a commit
that referenced
this pull request
Jul 20, 2012
Speed up allocateBranchIsland
|
When we updated mach_override to HEAD in chromium (to pick up 34048d9), it stopped working for us (http://crbug.com/141707). It's somewhat likely that something in this pull request is to blame. |
|
Yup, I rebooted mach_override into its own repo and got tests running again, and for whatever reason these changes cause the tests to fail. I've backed out the changes. @espindola please try to repro the test failures with these changes on your end, make them pass and then resubmit your pull request via the mach_override repo. |
mkrautz
pushed a commit
to mumble-voip/mach_override
that referenced
this pull request
Feb 5, 2015
and rentzsch/mach_star#39. They were causing basic tests to fail (10.8 x86_64).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are using mach_override at mozilla and noticed that allocateBranchIsland was really slow in some cases (https://bugzilla.mozilla.org/show_bug.cgi?id=773903).
In the process of figuring out what was going on I also simplified the code a bit.
P.S.: some of the patches look a lot smaller with diff -b