Expose allAttributes and allRelationships, related to #328 #360
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do you mind sharing your use-case? |
|
I should clarify: The code looks fine (simpler than I first surmised), but it's not used by anything else in mogenerator. That means it won't/can't be tested. |
|
Nevermind, I am an idiot and didn't read #328. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Expose an allAttributes and allRelationships accessors so that code can be generated to also reference descriptions excluded by noninheritedAttributes and noninheritedRelationships.
Addresses
Addresses EntityAttributes should also be present in ChildEntity-Attributes