-
Notifications
You must be signed in to change notification settings - Fork 171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
new option "switch-threshold" #261
Conversation
@dvarrazzo is this PR still valid? |
I haven't reviewed it. I am not working actively on the project at the moment. |
Can we merge this pull request? |
@gsmol Can you please rebase this PR? This will also trigger the checks. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
@andreasscherbaum I triggered tests in a separate branch:
https://github.com/adjust/pg_repack/commits/switch_threshold
Looks good. Although I think the short version for this option is unnecessary. Also it probably makes sense to increase the default value (at least up to 100). |
This branch has conflicts which need to be resolved. |
Because the PR is created from private branch |
Handled in this PR: #347 |
Hello!
Recently, when running pg_repack on really busy table, we were unable to catchup due to MIN_TUPLES_BEFORE_SWITCH been less than the size of average insert, populating the table.
So I would like to propose the patch, which should remedy such situations by parameterizing the switch threshold value instead of using macro. New options is "-r | --switch-threshold"
Thank you for a great tool.