Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new option "switch-threshold" #261

Closed
wants to merge 2 commits into from
Closed

Conversation

gsmolk
Copy link

@gsmolk gsmolk commented Dec 24, 2020

Hello!
Recently, when running pg_repack on really busy table, we were unable to catchup due to MIN_TUPLES_BEFORE_SWITCH been less than the size of average insert, populating the table.
So I would like to propose the patch, which should remedy such situations by parameterizing the switch threshold value instead of using macro. New options is "-r | --switch-threshold"

Thank you for a great tool.

@czhc
Copy link

czhc commented Nov 14, 2022

@dvarrazzo is this PR still valid?

@dvarrazzo
Copy link
Member

@dvarrazzo is this PR still valid?

I haven't reviewed it. I am not working actively on the project at the moment.

@MichaelDBA
Copy link
Collaborator

Can we merge this pull request?

@andreasscherbaum
Copy link
Collaborator

@gsmol Can you please rebase this PR? This will also trigger the checks. Thanks!

Copy link
Collaborator

@za-arthur za-arthur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.
@andreasscherbaum I triggered tests in a separate branch:
https://github.com/adjust/pg_repack/commits/switch_threshold

Related issue: #126, and PR: #147.

@Melkij
Copy link
Collaborator

Melkij commented Apr 6, 2023

Looks good. Although I think the short version for this option is unnecessary. Also it probably makes sense to increase the default value (at least up to 100).

@andreasscherbaum
Copy link
Collaborator

This branch has conflicts which need to be resolved.

@za-arthur
Copy link
Collaborator

Because the PR is created from private branch gsmol:switch_threshold to rebase and resolve conflicts I created new PR:
#347

@andreasscherbaum
Copy link
Collaborator

Handled in this PR: #347

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants