Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add posthog to system #239

Merged
merged 7 commits into from
May 6, 2024
Merged

add posthog to system #239

merged 7 commits into from
May 6, 2024

Conversation

chuyouchia
Copy link
Collaborator

Fairly simple, non-intrusive counting analytics using posthog.

src/App.tsx Outdated
import posthog from "posthog-js";

posthog.init("phc_xi4hFToX1cZU657yzge1VW0XImaaRzuvnFUdbAKI8fu", {
api_host: "https://us.i.posthog.com",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a bit 👎 on this. I use ollama and a local tool to avoid sending anything to the internet.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a tradeoff we need to strike. We can't build great products without at least partially knowing which features users like and which they don't.

This code change only sends counting metrics and nothing else. Do you not think this is a reasonable tradeoff? We will never send personal data to Posthog...

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I hear you. Essentially it's your call.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

opt-out maybe?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep thanks for the feedback @sebastian-philipp. We will implement opt-out too.

Copy link
Collaborator

@samlhuillier samlhuillier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@samlhuillier samlhuillier merged commit 7d7a89f into main May 6, 2024
0 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants