Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed operation not permitted when renaming directory with children in windows #249

Merged
merged 2 commits into from
May 11, 2024

Conversation

milaiwi
Copy link
Collaborator

@milaiwi milaiwi commented May 9, 2024

From #174. Users can now rename directories that contain file contents. Does so by:

  • Checking if user is running in windows environment,
  • Saving all watcher paths
  • Closing all watcher objects
  • Renaming file
  • Re-opening all watcher objects

…with children if running on Windows.

Signed-off-by: MoTheRoar <milaiwi@outlook.com>
…with children if running on Windows.

Signed-off-by: Mohamed Ilaiwi <burmoh@gmail.com>
Copy link
Collaborator

@samlhuillier samlhuillier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks for fixing this issue!

@samlhuillier samlhuillier merged commit 6bd4133 into reorproject:main May 11, 2024
0 of 4 checks passed
@milaiwi milaiwi deleted the windows_bug branch August 11, 2024 06:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants