feat: watch register behalf #41
Conversation
relay_client/src/http.rs
Outdated
| @@ -280,7 +288,11 @@ impl Client { | |||
| let status = result.status(); | |||
|
|
|||
| if !status.is_success() { | |||
| return Err(HttpClientError::InvalidHttpCode(status).into()); | |||
| let body = match result.text().await { | |||
There was a problem hiding this comment.
I'd use result.text().await.unwrap_or_else(|err| format!("... error calling result.text(): {err:?}")). Also the message is a bit strange. Maybe it should be something like 'error reading response body'?
There was a problem hiding this comment.
| @@ -66,7 +66,7 @@ fmt: | |||
|
|
|||
| if command -v cargo-fmt >/dev/null; then | |||
| echo '==> Running rustfmt' | |||
| cargo +nightly fmt --all -- --check | |||
| cargo +nightly fmt --all | |||
There was a problem hiding this comment.
Why the change? This was used for validation, along with clippy to make everything is all right before pushing. Formatting is usually done on the fly by the editor.
There was a problem hiding this comment.
My editor (vscode) doesn't format all of the way that cargo fmt does, so cargo fmt sometimes does extra stuff or I miss it in a certain file.
I use 1 command in my devloop, something like just fmt clippy test. So when I get a formatting error then I have to manually run cargo fmt. I'd rather it fix my formatting for me, rather than tell me it's wrong.
There was a problem hiding this comment.
I see. It hasn't been a problem for me, ever, in VSCode. Maybe you forgot to enable the +nightly feature in your VSCode addons?
There was a problem hiding this comment.
I can check this, but either way, wouldn't it be better to auto-format instead of just checking? What if my VS Code is out-of-sync with my CI/just tooling?
There was a problem hiding this comment.
Sure, as long as we still check formatting on the CI.
There was a problem hiding this comment.
Absolutely! No doubt about that :)
Description
watch_register_behalf()function which allows passing-throughregister_authpayload from clientjust fmtwill auto-format instead of just--checkget_message_id()refactor left-over from feat: expose message_id #39Resolves #40
How Has This Been Tested?
With archive refactor
Due Diligence