reproduce problem with resources: create a html page with several images

[asolntsev]

No description provided.

[xabolcs]

Maybe nitpicking, but in commit "log the error when Netty failed to print out response" you wrote unexpected message type: DefaultHttpResponse, but in the test I got unexpected message type: DefaultFullHttpResponse, state: 1 where state 1 is ST_CONTENT_NON_CHUNK:

    09:40:35,392 ERROR ~ failed to serve GET /img/benks-kyiv-4.jpeg (status: 404 Not Found)
    io.netty.handler.codec.EncoderException: java.lang.IllegalStateException: unexpected message type: DefaultFullHttpResponse, state: 1
        at io.netty.handler.codec.http.HttpObjectEncoder.write(HttpObjectEncoder.java:108)
        at io.netty.channel.CombinedChannelDuplexHandler.write(CombinedChannelDuplexHandler.java:346)
        at io.netty.channel.AbstractChannelHandlerContext.invokeWrite0(AbstractChannelHandlerContext.java:879)
        at io.netty.channel.AbstractChannelHandlerContext.invokeWrite(AbstractChannelHandlerContext.java:863)
        at io.netty.channel.AbstractChannelHandlerContext.write(AbstractChannelHandlerContext.java:968)
        at io.netty.channel.AbstractChannelHandlerContext.write(AbstractChannelHandlerContext.java:856)
        at io.netty.handler.stream.ChunkedWriteHandler.doFlush(ChunkedWriteHandler.java:302)
        at io.netty.handler.stream.ChunkedWriteHandler.flush(ChunkedWriteHandler.java:131)
        at io.netty.channel.AbstractChannelHandlerContext.invokeFlush0(AbstractChannelHandlerContext.java:923)
        at io.netty.channel.AbstractChannelHandlerContext.invokeWriteAndFlush(AbstractChannelHandlerContext.java:941)
        at io.netty.channel.AbstractChannelHandlerContext$WriteTask.run(AbstractChannelHandlerContext.java:1247)
        at io.netty.util.concurrent.AbstractEventExecutor.runTask(AbstractEventExecutor.java:174)
        at io.netty.util.concurrent.AbstractEventExecutor.safeExecute(AbstractEventExecutor.java:167)
        at io.netty.util.concurrent.SingleThreadEventExecutor.runAllTasks(SingleThreadEventExecutor.java:470)
        at io.netty.channel.nio.NioEventLoop.run(NioEventLoop.java:569)
        at io.netty.util.concurrent.SingleThreadEventExecutor$4.run(SingleThreadEventExecutor.java:997)
        at io.netty.util.internal.ThreadExecutorMap$2.run(ThreadExecutorMap.java:74)
        at io.netty.util.concurrent.FastThreadLocalRunnable.run(FastThreadLocalRunnable.java:30)
        at java.base/java.lang.Thread.run(Thread.java:829)
    Caused by: java.lang.IllegalStateException: unexpected message type: DefaultFullHttpResponse, state: 1
        at io.netty.handler.codec.http.HttpObjectEncoder.throwUnexpectedMessageTypeEx(HttpObjectEncoder.java:348)
        at io.netty.handler.codec.http.HttpObjectEncoder.encodeFullHttpMessage(HttpObjectEncoder.java:305)
        at io.netty.handler.codec.http.HttpObjectEncoder.encode(HttpObjectEncoder.java:162)
        at io.netty.handler.codec.http.HttpObjectEncoder.write(HttpObjectEncoder.java:97)
        ... 18 more

It dies because the message is a FullHttpMessage and the state is not ST_INIT so is something is already sent out.

Browsing HttpObjectEncodeer.encode() there are a few hints how these message types relate to states.
But I still don't know that servexxx() should use FullHttpResponse and something is wrong with sending the headers before, or the serverxxx() shouldn't use FullHttpResponse because the headers are sent already. 🙃

[xabolcs]

There isn't much in the "New and noteworthy in 4.0" document, but it worth to read.

And here is the referenced http snoop example: Package io.netty.example.http.snoop

[asolntsev]

I registered an issue for replay-netty4: #157