Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support command callbacks using CDP #2

Closed
bhackett1024 opened this issue Mar 25, 2021 · 1 comment
Closed

Support command callbacks using CDP #2

bhackett1024 opened this issue Mar 25, 2021 · 1 comment
Assignees
@bhackett1024

Comments

@bhackett1024
Copy link

In the node port we have some JS code that handles commands from the driver by synchronously running commands over the CDP. We should port this over to chromium because it's nice and clean and having two identical implementations will make it easier to keep this stuff in sync over time.
bhackett1024 added a commit that referenced this issue Mar 25, 2021
@bhackett1024
Incorporate command callback handling JS, for #2
998d2ef
bhackett1024 added a commit that referenced this issue Mar 26, 2021
@bhackett1024
Connect CDP message callbacks to inspector agent, for #2
c829c73
@bhackett1024
Copy link
Author

We're now using the JS code from node for accessing the CDP and inspecting chromium's state while paused. This works well enough that at our first devtools e2e test (breakpoints-01.js) passes when using chromium to record.

Screen Shot 2021-03-26 at 9 39 12 AM

@bhackett1024 bhackett1024 self-assigned this Mar 27, 2021
bhackett1024 pushed a commit that referenced this issue Jan 7, 2023
@bergeret
[shutdown 1/2] Ensure ProcessExiting(...) is always called
e60bbf1 
This CL is fixing the bucket for ShutdownType2 for process
that do an early exit within BasicStartupComplete(...).

These cases can be repro on Linux with these commands:

1) ./chrome --version
2) ./chrome --product-version
3) ./chrome --credits
4) ./chrome --diagnostics

The ChromeMainDelegate must be robust for cases where the
BasicStartupComplete is not fully executed due to an error
(early exits).

The chrome logging was assuming it was initialized. This CL is
ensuring the code was initialized to call the corresponding
shutdown code.

[1004/174420.541708:FATAL:logging_chrome.cc(468)] Check failed: chrome_logging_initialized_. Attempted to clean up logging when it wasn't initialized.
#0 0x55a6a8cf8952 base::debug::CollectStackTrace()
#1 0x55a6a8be9cc3 base::debug::StackTrace::StackTrace()
#2 0x55a6a8c0468f logging::LogMessage::~LogMessage()
#3 0x55a6a8c0549e logging::LogMessage::~LogMessage()
#4 0x55a6ab92495b logging::CleanupChromeLogging()
#5 0x55a6a355f45b ChromeMainDelegate::ProcessExiting()
#6 0x55a6a85ed50d content::ContentMainRunnerImpl::Shutdown()
#7 0x55a6a85eaddb content::ContentMainRunnerImpl::~ContentMainRunnerImpl()
#8 0x55a6a85eaf1e content::ContentMainRunnerImpl::~ContentMainRunnerImpl()
#9 0x55a6a85e8bb0 content::ContentMain()
#10 0x55a6a355d236 ChromeMain
#11 0x7fc168e4781d __libc_start_main
#12 0x55a6a355d02a _start


Change-Id: I51c9d7b18535f69d6733a8d0b88d0a80111bdcb7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3931775
Reviewed-by: Ken Rockot <rockot@google.com>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Commit-Queue: Etienne Bergeron <etienneb@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1058086}
Domiii added a commit that referenced this issue Mar 13, 2023
@Domiii
RUN-1430 #2: fix getObjectPreview (getProperties) crashes #459
9e95f21
@Domiii Domiii mentioned this issue May 10, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bhackett1024 bhackett1024

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@bhackett1024