Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

500+ hits error should link to Focus Mode, not docs about Focus Mode #25

Closed
jonbell-lot23 opened this issue Apr 18, 2022 · 6 comments · Fixed by replayio/devtools#6638
Closed
Assignees

Comments

@jonbell-lot23
Copy link

Right now this happens:

  1. 500+ limit
  2. User has to know to go to Focus Mode
  3. User drags one side in
  4. User drags the other side in
  5. User clicks away to commit
  6. User tries again

This should be replaced with two things:

  1. Messaging about Focus Mode (I thought we did this already but maybe not)
  2. A single click that applies focus mode to the point you're paused on
@jasonLaster
Copy link
Contributor

@jonbell-lot23 here is an example of a hot print statement today.

I like the idea of an button that launches focus mode with a "best guess" window.

I also wonder if it is time to begin discussing some other frontend improvements we could do as well
#36

The biggest one that we could do which we can discuss in #36 is adding the ability to progressively evaluate more expressions. How would this work

  1. user adds a new print statement with 500+ calls
  2. we show 200 messages in the console
  3. user wants to see an additional 200 messages, they can either
    3.a click a load more button
    3.b select a window in the print statement panel and select the next batch they want to load

@jcmorrow
Copy link

I like the idea of an button that launches focus mode with a "best guess" window.

Yeah, even in cases where we have thousands of analysis points, we often get back usable results from the backend, and a thing that would be nice is to say "I only ever want to see a window of ten of these in the console, and let's start by using the ten that are closest to my current timestamp". This would actually be really handy for all print statements, even the print statements that are only 200 hits - often the analysis takes a long time because there are so many points to evaluate, when in truth you might not care about 99% of those evaluations.

@jcmorrow
Copy link

If I had an interface to say "I want to see X neighboring hits, centered around Y time or the Zth hit" I think that would be 🤌

@jonbell-lot23
Copy link
Author

Here's my short term proposal before we get to Focus Mode 1.1 and #36 :

Right now the page links to docs ->
image

I think clicking on the words "Focus Mode" should instead trigger our actual Focus Mode. That's a quick win that sets up our broader ideas. Thoughts?

@jonbell-lot23 jonbell-lot23 changed the title 500+ hits error should have a way to go straight to Focus Mode 500+ hits error should link to Focus Mode, not docs about Focus Mode Apr 28, 2022
@jonbell-lot23 jonbell-lot23 removed their assignment Apr 28, 2022
@jonbell-lot23
Copy link
Author

Marking as design complete and tapping @jcmorrow and @jasonLaster on the shoulder for:

  1. Thumbs up
  2. Assigning it to someone to make this quick link (not me, I have a big stack of design tasks)
  3. Pivoting our attention over to Improve support for print statements with 200+ messages #36

@jcmorrow
Copy link

Yeah I'm happy to knock this out as a bandaid pre #36

jcmorrow added a commit to replayio/devtools that referenced this issue May 2, 2022
jcmorrow added a commit to replayio/devtools that referenced this issue May 2, 2022
jcmorrow added a commit to replayio/devtools that referenced this issue May 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants