Do a better job when external calls can't be performed #50
Labels
enhancement
New feature or request
Milestone
Comments
bhackett1024
pushed a commit
that referenced
this issue
Mar 27, 2020
Pick commits: - 7fe03b4: Bail out if the output device has no output channel (#50) - ad74bad: Update README - 3f38b17: Replace `*.get_mut()` by `*.store()` on all the `Atomic*` (#47) - b1bc781: Run tests by sanitizers (#46) Differential Revision: https://phabricator.services.mozilla.com/D62654 --HG-- extra : source : 24b97b0c24f0f30965d5d30dfa2a796e3c994e5e
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
After the changes in cd5cf44, we use dummy (generally zero) values for the outputs of external calls whose outputs we couldn't find in the recording. External calls are mainly used for rendering fonts and widgets, and this can lead to text or widgets missing in the rendered output or being rendered as black boxes. After #49 we'll show an indicator in this case, but it would be good if this wasn't so distracting and we showed something very similar at least to what the real output would be. We could look through the recording for similar calls whose outputs we could use, or we could perform some limited emulation of these calls on the host linux system.
The text was updated successfully, but these errors were encountered: